Re: [PATCH -v1 3/3] usbnet: handle remote wakeup asap

Am Mittwoch, 20. Juni 2012, 13:02:12 schrieb Sergei Shtylyov:

quoted

Without the patch, usbnet can't recieve any packets from peer
in runtime suspend state if runtime PM is enabled and
autosuspend_delay is set as zero.

quoted

Signed-off-by: Ming Lei<redacted>
---
  drivers/net/usb/usbnet.c |   42 ++++++++++++++++++++++++++----------------
  1 file changed, 26 insertions(+), 16 deletions(-)

quoted

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 9bfa775..a89d6c5 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c

@@ -1201,6 +1201,21 @@ deferred:
  }
  EXPORT_SYMBOL_GPL(usbnet_start_xmit);

+static void rx_alloc_submit(struct usbnet *dev, gfp_t flags)
+{
+     struct urb      *urb;
+     int             i;
+
+     /* don't refill the queue all at once */
+     for (i = 0; i<  10&&  dev->rxq.qlen<  RX_QLEN(dev); i++) {
+             urb = usb_alloc_urb(0, flags);
+             if (urb != NULL) {
+                     if (rx_submit(dev, urb, flags) == -ENOLINK)

    The above 2 if statements can be collapsed into single one.

That would not improve readability.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html