Re: [PATCH] usbnet: Activate halt interrupt endpoint before re-submit URB

Am Montag, 18. Juni 2012, 18:25:15 schrieb Huajun Li:

On Mon, Jun 18, 2012 at 3:23 PM, Oliver Neukum [off-list ref] wrote:

quoted

Am Montag, 18. Juni 2012, 01:30:17 schrieb David Miller:

quoted

From: Huajun Li <redacted>
Date: Wed, 13 Jun 2012 20:50:31 +0800

quoted

intr_complete() submits URB even the interrupt endpoint stalls.
This patch will try to activate the endpoint once the exception
occurs, and then re-submit the URB if the endpoint works again.

Signed-off-by: Huajun Li <redacted>

Review from USB experts would be appreciated.

The code implements a minimum error handler correctly.
Did you observe a stall in actual hardware or is this a just
in case patch?

This one is just a patch, thanks for your comments.

Very well, on second thought, this patch makes sense.
Could you resend and I'll ack?

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html