Thread (7 messages) flat view 7 messages, 3 authors, 2012-06-19

Re: [PATCH net-next] ixgbe: simplify padding and length checks (v2)

From: Jeff Kirsher <hidden>
Date: 2012-06-19 23:31:47

On Mon, 2012-06-18 at 16:31 -0700, Stephen Hemminger wrote:
The check for length <= 0 is bogus because length is unsigned, and
network
stack never sends zero length packets (unless it is totally broken).

The check for really small packets can be optimized (using unlikely)
and calling skb_pad directly.

Signed-off-by: Stephen Hemminger <redacted> 
I just realized I had not responded to this updated patch.

Thanks Stephen, I have dropped your previous 2 patch series and added
this patch to my queue.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help