Re: [RFC net-next 01/14] Add Default
From: Alexander Duyck <hidden>
Date: 2012-06-19 16:37:34
On 06/19/2012 08:13 AM, Yuval Mintz wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Yuval Mintz <redacted> Signed-off-by: Eilon Greenstein <redacted> --- include/linux/etherdevice.h | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h index 3d406e0..bb1ecaf 100644 --- a/include/linux/etherdevice.h +++ b/include/linux/etherdevice.h@@ -44,7 +44,10 @@ extern int eth_mac_addr(struct net_device *dev, void *p); extern int eth_change_mtu(struct net_device *dev, int new_mtu); extern int eth_validate_addr(struct net_device *dev); - +/* The maximal number of RSS queues a driver should have unless configured + * so explicitly. + */ +#define DEFAULT_MAX_NUM_RSS_QUEUES (8) extern struct net_device *alloc_etherdev_mqs(int sizeof_priv, unsigned int txqs, unsigned int rxqs);
I'm not a big fan of just having this as a fixed define in the code. It seems like it would make much more sense to have this in the Kconfig somewhere as a range value if you plan on making this changeable in the future. Thanks, Alex