Re: [PATCH] net: added support for 40GbE link.

From: Ben Hutchings <redacted>
Date: Mon, 18 Jun 2012 18:09:36 +0100

On Mon, 2012-06-18 at 18:14 +0530, Parav Pandit wrote:

...

quoted

-/* The forced speed, 10Mb, 100Mb, gigabit, 2.5Gb, 10GbE. */
+/* The forced speed, 10Mb, 100Mb, gigabit, 2.5Gb, 10GbE, 40GbE. */

I don't think there's any need to name all possible link speeds, and it
just encourages the bad practice of ethtool API users checking for
specific values.  You may notice there is no SPEED_20000.

Agreed.

quoted

@@ -542,13 +542,11 @@ static int prb_calc_retire_blk_tmo(struct packet_sock *po,

 ...

This function should be fixed properly.  Firstly, it must use
ethtool_cmd_speed() rather than directly accessing ecmd.speed.
Secondly, it should allow any speed value rather than checking for
specific values.  Then there will be no need to make further changes for
100G or any other new speed.

Agreed.