Thread (3 messages) flat view 3 messages, 2 authors, 2012-06-16

Re: [PATCH] ipv6: Handle PMTU in ICMP error handlers.

From: Neal Cardwell <ncardwell@google.com>
Date: 2012-06-16 02:42:27

On Fri, Jun 15, 2012 at 6:00 PM, David Miller [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+++ b/include/net/ip6_route.h
+extern void ip6_update_pmtu(struct sk_buff *skb, struct net *net, __be32 mtu,
+                           int oif, u32 mark);
...
quoted hunk ↗ jump to hunk
+++ b/net/ipv6/route.c
+void ip6_update_pmtu(struct sk_buff *skb, struct net *net, u32 mtu,
+                    int oif, __be32 mark)
The .h and .c files disagree on the types of mtu and mark for
ip6_update_pmtu(). Looks like the mtu should be __be32 in both. I'm
guessing mark should also be __be32 in both, though I'm not yet
familiar with that area of the code.

Otherwise looks great to me.

neal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help