Thread (7 messages) flat view 7 messages, 3 authors, 2012-06-12

Re: [PATCH] netpoll: Fix skb tail pointer in netpoll_send_udp()

From: Eric Dumazet <hidden>
Date: 2012-06-12 13:34:16

On Tue, 2012-06-12 at 15:15 +0200, Eric Dumazet wrote:
On Tue, 2012-06-12 at 14:22 +0200, Eric Dumazet wrote:
quoted
Hmm, real question is why skb_realloc_headroom() is even necessary...

I suspect we need to reserve more bytes.

	total_len = ip_len + ETH_HLEN + NET_IP_ALIGN + NET_SKB_PAD;

or something like that ?

Which driver triggers the bug ?
In case you wonder why I try so hard to avoid the
skb_realloc_headroom() :

netpoll has complicated^Wspecial^Wnice skb cache, to make sure it can
work even if memory is exhausted.

But if we trigger skb_realloc_headroom() the whole thing is useless. 

Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help