Re: [PATCH] usbnet: Activate the halt interrupt endpoint to fix endless "XactErr" error

On Tue, Jun 12, 2012 at 4:47 AM, Bjørn Mork [off-list ref] wrote:

Huajun Li [off-list ref] writes:

quoted

diff --git a/include/linux/usb/usbnet.h b/include/linux/usb/usbnet.h
index 76f4396..c0bcb61 100644
--- a/include/linux/usb/usbnet.h
+++ b/include/linux/usb/usbnet.h

@@ -62,13 +62,14 @@ struct usbnet {

      unsigned long           flags;
 #            define EVENT_TX_HALT    0
 #            define EVENT_RX_HALT    1
-#            define EVENT_RX_MEMORY  2
-#            define EVENT_STS_SPLIT  3
-#            define EVENT_LINK_RESET 4
-#            define EVENT_RX_PAUSED  5
-#            define EVENT_DEV_WAKING 6
-#            define EVENT_DEV_ASLEEP 7
-#            define EVENT_DEV_OPEN   8
+#            define EVENT_STS_HALT   2
+#            define EVENT_RX_MEMORY  3
+#            define EVENT_STS_SPLIT  4
+#            define EVENT_LINK_RESET 5
+#            define EVENT_RX_PAUSED  6
+#            define EVENT_DEV_WAKING 7
+#            define EVENT_DEV_ASLEEP 8
+#            define EVENT_DEV_OPEN   9
 };

Why do you renumber all of these instead of adding the new
EVENT_STS_HALT to the end of the list?

Thanks for your comments.

I think it's nice to sort these mask codes by their purposes.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html