Re: [PATCH] net: sierra_net: device IDs for Aircard 320U++

On Wed, Jun 06, 2012 at 10:19:15AM +0200, Bjørn Mork wrote:

Greg KH [off-list ref] writes:

quoted

On Wed, Jun 06, 2012 at 09:18:10AM +0200, Bjørn Mork wrote:

quoted

Adding device IDs for Aircard 320U and two other devices
found in the out-of-tree version of this driver.

Cc: linux-ywE8TTl5eJHWpu6QEFMNjNBPR1lH4CV8@public.gmane.org
Cc: Autif Khan <redacted>
Cc: Tom Cassidy <redacted>
Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Bjørn Mork <redacted>
---
 drivers/net/usb/sierra_net.c |   14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

Wait, Tom just sent me a patch adding these device ids to the sierra
serial driver, why would the same device work for both drivers?

Because it's a composite device.  Was this a trick question? :-)

quoted

 Where should the device id go?

To both drivers.  The device is similar to the 1199:68a3 device already
supported by both drivers.  It has a number of serial ports (depending
on how many features like GPS etc is enabled) supported by the "sierra"
driver and one ethernet interface speaking Sierra's HIP protocol
supported by the "sierra_net" driver.

Ok, thanks for clearing that up, I'll take the serial patch, and I'm
sure that David will take this one.

	Acked-by: Greg Kroah-Hartman [off-list ref]

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html