Re: [PATCH] macvtap: use set_curren_state to ensure mb
From: Hong zhi guo <hidden>
Date: 2012-06-05 10:57:03
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2012-06-06 · Re: [PATCH] macvtap: use set_curren_state to ensure mb · David Miller <davem@davemloft.net>
- 2012-06-05 · Re: [PATCH] macvtap: use set_curren_state to ensure mb · Hong zhi guo <hidden>
- 2012-06-05 · Re: [PATCH] macvtap: use set_curren_state to ensure mb · Eric Dumazet <hidden>
- 2012-06-05 · [PATCH] macvtap: use set_curren_state to ensure mb · Hong zhi guo <hidden>
On Tue, Jun 5, 2012 at 6:46 PM, Hong zhi guo [off-list ref] wrote:
replace raw assignment of current->state with set_current_state(TASK_...) to ensure memory barrier. Signed-off-by: Hong Zhiguo <redacted>
Sorry for the wrong format in former mail. Corrected. Signed-off-by: Hong Zhiguo <redacted> --- drivers/net/macvtap.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 2ee56de..62754f6 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c@@ -853,7 +853,7 @@ static ssize_t macvtap_do_read(structmacvtap_queue *q, struct kiocb *iocb,
add_wait_queue(sk_sleep(&q->sk), &wait);
while (len) {
- current->state = TASK_INTERRUPTIBLE;
+ set_current_state(TASK_INTERRUPTIBLE);
/* Read frames from the queue */
skb = skb_dequeue(&q->sk.sk_receive_queue);@@ -875,7 +875,7 @@ static ssize_t macvtap_do_read(structmacvtap_queue *q, struct kiocb *iocb, break; } - current->state = TASK_RUNNING; + set_current_state(TASK_RUNNING); remove_wait_queue(sk_sleep(&q->sk), &wait); return ret; } -- 1.7.4.1