Re: [PATCH (net.git) 3/3] stmmac: fix driver Kconfig when built as module

On 6/4/2012 6:45 PM, Ben Hutchings wrote:

On Mon, 2012-06-04 at 18:32 +0200, Giuseppe CAVALLARO wrote:

quoted

This patches fixes the driver when built as dyn module.
In fact the platform part cannot be built and the probe fails
(thanks to Bob Liu that reported this bug).

v2: as D. Miller suggested, it is not necessary to make the
pci and the platform code mutually exclusive.
Having both could also help, at built time ,to verify that
all the code is validated and compiles fine.

Reported-by: Bob Liu <redacted>
Signed-off-by: Giuseppe Cavallaro <redacted>
Reviewed-by: Ben Hutchings <redacted>

[...]

What I said in <1337687765.11796.11.camel@deadeye> was:

That's because CONFIG_STMMAC_PLATFORM and CONFIG_STMMAC_PCI are wrongly
declared as tristate in Kconfig.  Change them to bool and it should work
again.

You can't add a 'Reviewed-by' line on the basis of this; you can only
add it if a reviewer writes that line themselves (and if you don't make
further changes).

Thanks, I'm sending the patches again and sorry for the wrong usage of
Reviewed-by.

Peppe

Ben.