Thread (8 messages) flat view 8 messages, 6 authors, 2012-05-08

Re: batostr() function

From: Andrei Emeltchenko <hidden>
Date: 2012-05-08 14:30:12
Also in: linux-bluetooth

On Tue, May 08, 2012 at 04:25:08PM +0200, Johannes Berg wrote:
On Tue, 2012-05-08 at 15:30 +0200, David Herrmann wrote:
quoted
Hi Johannes

On Mon, May 7, 2012 at 1:49 PM, Johannes Berg [off-list ref] wrote:
quoted
Really? 2 static buffers that are used alternately based on a static
variable? How can that possibly be thread-safe? That may work in very
restricted scenarios, but ...
Looking at "git blame" it seems the whole function is still from
linux-2.4. Looks like no-one ever noticed. I've sent a patchset fixing
it, thanks.
I was thinking you could use %pM, but it seems BT addresses are stored
the wrong way around for some reason ...
This looks like better idea then allocating buffers, we can use swap to
take care about "wrong order".

Best regards 
Andrei Emeltchenko 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help