Re: [PATCH V2] ipv4: fix the rcu race between free_fib_info and ip_route_output_slow

From: Eric Dumazet <redacted>
Date: Thu, 24 May 2012 04:42:42 +0200

On Thu, 2012-05-24 at 09:39 +0800, kun.jiang wrote:

quoted

From: Yanmin Zhang <redacted>

We hit a kernel OOPS.

...

quoted

Function free_fib_info resets nexthop_nh->nh_dev to NULL before releasing
fi. Other cpu might be accessing fi. Fixing it by delaying the releasing.

With the patch, we ran MTBF testing on Android mobile for 12 hours
and didn't trigger the issue.

Thank Eric for very detailed review/checking the issue.

Signed-off-by: Yanmin Zhang <redacted>
Signed-off-by: Kun Jiang <redacted>
---
 net/ipv4/fib_semantics.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

Acked-by: Eric Dumazet <edumazet@google.com>

Applied, thanks everyone.