Re: [PATCH] ipv4: fix the rcu race between free_fib_info and ip_route_output_slow

On Wed, 2012-05-23 at 14:47 +0800, Yanmin Zhang wrote:

On Wed, 2012-05-23 at 08:27 +0200, Eric Dumazet wrote:

quoted

On Wed, 2012-05-23 at 14:15 +0800, Yanmin Zhang wrote:

quoted

Besides fi->fib_dev here, we need check fi->fib_hash, fi->fib_lhash,
and nexthop_nh->nh_hash.

No, its not needed.

I am checking it now.
fib_create_info=>fib_find_info, but fib_find_info is not protected by
fib_info_lock. See the codes:


link_it:
        ofi = fib_find_info(fi);
        if (ofi) {
                fi->fib_dead = 1;
                free_fib_info(fi);
                ofi->fib_treeref++;
                return ofi;
        }

quoted

I am sending a patch, because I feel this area is too complex for non
netdev guys.

Indeed, it's complicated. I will test your patches.

Please hold on, I'll send a v2