Thread (7 messages) flat view 7 messages, 4 authors, 2012-05-14

Re: [PATCH] net: codel: fix build errors

From: Sasha Levin <hidden>
Date: 2012-05-14 21:39:32
Also in: lkml

On Mon, May 14, 2012 at 11:08 PM, Eric Dumazet [off-list ref] wrote:
Anonymous unions are fine, we use them a lot in kernel.
While we use them a lot, we don't try initializing them that often.
Please fix the initializers instead in fq_codel_dump_stats(), because
these two #define are not very nice.
The only method I know of fixing that up is getting braces around them
in the initializer, which is hacky and will break every time a new
member is added to the struct before the anonymous union. Is there a
different solution?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help