Re: [PATCH] net: of/phy: fix build error when phylib is built as a module
From: Randy Dunlap <hidden>
Date: 2012-05-11 23:50:07
Also in:
linux-next, linuxppc-dev, lkml
On 05/11/2012 08:47 AM, Bjørn Mork wrote:
CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m. Use IS_ENABLED macro to prevent build error: ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined! Reported-by: Randy Dunlap <redacted> Cc: David Daney <redacted> Signed-off-by: Bjørn Mork <bjorn@mork.no>
Acked-by: Randy Dunlap <redacted> Thanks.
quoted hunk ↗ jump to hunk
--- I wonder if this could be as banal as this? Not even build tested... Should be wrapped into commit 25106022 if it works, to ensure bisectability. Bjørn drivers/net/phy/mdio_bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c index 83d5c9f..683ef1c 100644 --- a/drivers/net/phy/mdio_bus.c +++ b/drivers/net/phy/mdio_bus.c@@ -88,7 +88,7 @@ static struct class mdio_bus_class = { .dev_release = mdiobus_release, }; -#ifdef CONFIG_OF_MDIO +#if IS_ENABLED(CONFIG_OF_MDIO) /* Helper function for of_mdio_find_bus */ static int of_mdio_bus_match(struct device *dev, void *mdio_bus_np) {
-- ~Randy