Re: linux-next: Tree for May 10 (net/phy)

On 05/10/2012 02:26 AM, Stephen Rothwell wrote:

Hi all,

Changes since 20120508:

ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined!

Full randconfig file is attached.

-- 
~Randy

On Thu, May 10, 2012 at 5:40 PM, Randy Dunlap [off-list ref] wrote:

On 05/10/2012 02:26 AM, Stephen Rothwell wrote:

quoted

Hi all,

Changes since 20120508:

ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined!

Not just randconfig, but also powerpc allmodconfig:

http://kisskb.ellerman.id.au/kisskb/buildresult/6291463/

Adding ppc ML to cc.

P.
--

Full randconfig file is attached.

--
~Randy

From: Paul Gortmaker <redacted>
Date: Thu, 10 May 2012 22:36:55 -0400

On Thu, May 10, 2012 at 5:40 PM, Randy Dunlap [off-list ref] wrote:

quoted

On 05/10/2012 02:26 AM, Stephen Rothwell wrote:

quoted

Hi all,

Changes since 20120508:

ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined!

Not just randconfig, but also powerpc allmodconfig:

http://kisskb.ellerman.id.au/kisskb/buildresult/6291463/

Adding ppc ML to cc.

Adding the guilty party to the CC:.  This really stinks, especially
after I did give the patch submitter a hard time about getting the
dependencies right. :-/

CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m.  Use
IS_ENABLED macro to prevent build error:

 ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined!

Reported-by: Randy Dunlap <redacted>
Cc: David Daney <redacted>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
I wonder if this could be as banal as this?  Not even build tested...

Should be wrapped into commit 25106022 if it works, to ensure
bisectability.



Bjørn

 drivers/net/phy/mdio_bus.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 83d5c9f..683ef1c 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c

@@ -88,7 +88,7 @@ static struct class mdio_bus_class = {
 	.dev_release	= mdiobus_release,
 };
 
-#ifdef CONFIG_OF_MDIO
+#if IS_ENABLED(CONFIG_OF_MDIO)
 /* Helper function for of_mdio_find_bus */
 static int of_mdio_bus_match(struct device *dev, void *mdio_bus_np)
 {

-- 
1.7.10

On 05/10/2012 07:43 PM, David Miller wrote:

From: Paul Gortmaker<redacted>
Date: Thu, 10 May 2012 22:36:55 -0400

quoted

On Thu, May 10, 2012 at 5:40 PM, Randy Dunlap[off-list ref]  wrote:

quoted

On 05/10/2012 02:26 AM, Stephen Rothwell wrote:

quoted

Hi all,

Changes since 20120508:

ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined!

Not just randconfig, but also powerpc allmodconfig:

http://kisskb.ellerman.id.au/kisskb/buildresult/6291463/

Adding ppc ML to cc.

Adding the guilty party to the CC:.  This really stinks, especially
after I did give the patch submitter a hard time about getting the
dependencies right. :-/

Indeed, how embarrassing.

It looks like Bjørn may have already posted a fix.  I will try to verify 
that it works, and take appropriate action.

Sorry about the screw up,
David Daney

On 05/11/2012 08:47 AM, Bjørn Mork wrote:

CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m.  Use
IS_ENABLED macro to prevent build error:

  ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined!

Reported-by: Randy Dunlap<redacted>
Cc: David Daney<redacted>
Signed-off-by: Bjørn Mork<bjorn@mork.no>

I was able to reproduce the failure, and this patch both fixes it and 
seems correct, so...

Acked-by: David Daney<redacted>

Sorry about this failure.

From: Bjørn Mork <bjorn@mork.no>
Date: Fri, 11 May 2012 17:47:01 +0200

Should be wrapped into commit 25106022 if it works, to ensure
bisectability.

Wrapped into?

Commits made to my net-next tree are permanent and irreversible, so we
cannot go back and change a commit.  I never rebase my tree, too many
people use it directly and pull it into their tree, so I'd break their
world if I ever did that.

From: David Daney <redacted>
Date: Fri, 11 May 2012 10:58:06 -0700

On 05/11/2012 08:47 AM, Bjørn Mork wrote:

quoted

CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m.  Use
IS_ENABLED macro to prevent build error:

  ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined!

Reported-by: Randy Dunlap<redacted>
Cc: David Daney<redacted>
Signed-off-by: Bjørn Mork<bjorn@mork.no>

I was able to reproduce the failure, and this patch both fixes it and
seems correct, so...

Acked-by: David Daney<redacted>

Applied.

On 05/11/2012 08:47 AM, Bjørn Mork wrote:

CONFIG_OF_MDIO is tristate and will be m if PHYLIB is m.  Use
IS_ENABLED macro to prevent build error:

 ERROR: "of_mdio_find_bus" [drivers/net/phy/mdio-mux.ko] undefined!

Reported-by: Randy Dunlap <redacted>
Cc: David Daney <redacted>
Signed-off-by: Bjørn Mork <bjorn@mork.no>

Acked-by: Randy Dunlap <redacted>

Thanks.

-- 
~Randy