Thread (2 messages) 2 messages, 2 authors, 2012-05-10

Re: [PATCH 00/13] net: Add and use ether_addr_equal

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2012-05-10 06:57:02
Also in: bridge, linux-bluetooth, linux-wireless, lkml, netfilter-devel

On Wed, 2012-05-09 at 23:54 -0700, Joe Perches wrote:
On Thu, 2012-05-10 at 08:48 +0200, Johannes Berg wrote:
quoted
On Wed, 2012-05-09 at 21:21 -0400, David Miller wrote:
quoted
That case you didn't convert in mac80211 is probably the
bug Johannes was talking about which started this whole
discussion.
The bug case that started it all is in net/wireless/scan.c and Emmanuel
has since changed it back to memcmp(). Not sure if that's the one you
were referring to or not :-)
That's the one that I left alone.

Post patch:
$ git grep -n -w compare_ether_addr net
net/batman-adv/main.h:198: * note: can't use compare_ether_addr() as it requires aligned memory
net/wireless/scan.c:381:        return compare_ether_addr(a->bssid, b->bssid);
Ok, great, then that means the fix from Emmanuel won't conflict when it
gets in.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help