[PATCH net 1/3] bql: Fix POSDIFF() to integer overflow aware.

From
Hiroaki SHIMODA <hidden>
Date
2012-05-30 22:24:43
POSDIFF() fails to take into account integer overflow case.

Signed-off-by: Hiroaki SHIMODA <redacted>
Cc: Tom Herbert <redacted>
Cc: Eric Dumazet <redacted>
Cc: Denys Fedoryshchenko <redacted>
---
 lib/dynamic_queue_limits.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/dynamic_queue_limits.c b/lib/dynamic_queue_limits.c
index 6ab4587..c87eb76 100644
--- a/lib/dynamic_queue_limits.c
+++ b/lib/dynamic_queue_limits.c
@@ -10,7 +10,7 @@
 #include <linux/jiffies.h>
 #include <linux/dynamic_queue_limits.h>
 
-#define POSDIFF(A, B) ((A) > (B) ? (A) - (B) : 0)
+#define POSDIFF(A, B) ((int)((A) - (B)) > 0 ? (A) - (B) : 0)
 
 /* Records completed count and recalculates the queue limit */
 void dql_completed(struct dql *dql, unsigned int count)
-- 
1.7.3.4
Thread (3 messages) 3 messages, 3 authors, last reply 2012-05-31
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help