Re: [PATCH 01/17] netfilter: add struct nf_proto_net for register l4proto sysctl

On Sat, May 26, 2012 at 10:28:33AM +0800, Gao feng wrote:

于 2012年05月25日 14:02, Gao feng 写道:

quoted

于 2012年05月25日 10:54, Pablo Neira Ayuso 写道:

[...]

quoted

quoted

Could you resolve this by checking pn->ctl_compat_header != NULL ?

pn->ctl_table_header and ctl_compat_header is shared by l4proto_tcp and l4proto_tcp6.
if we both register l4proto_tcp and l4proto_tcp6, when unregister l4proto_tcp6
pn->ctl_compat_header must not be NULL.

Maybe we can resolve this by  nf_conntrack_l4proto.l3proto == AF_INET &&  pn->ctl_compat_header != NULL
Because compat sysctl is registered by AF_INET's proto only.

OK, as soon as it can remove the compat field, I prefer it.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html