Thread (2 messages) flat view 2 messages, 2 authors, 2012-05-18

Re: [PATCH net-next] net: introduce netdev_alloc_frag()

From: David Miller <davem@davemloft.net>
Date: 2012-05-18 17:31:46

From: Eric Dumazet <redacted>
Date: Fri, 18 May 2012 17:12:12 +0200
From: Eric Dumazet <edumazet@google.com>

Fix two issues introduced in commit a1c7fff7e18f5
( net: netdev_alloc_skb() use build_skb() )

- Must be IRQ safe (non NAPI drivers can use it)
- Must not leak the frag if build_skb() fails to allocate sk_buff

This patch introduces netdev_alloc_frag() for drivers willing to
use build_skb() instead of __netdev_alloc_skb() variants.

Factorize code so that :
__dev_alloc_skb() is a wrapper around __netdev_alloc_skb(), and
dev_alloc_skb() a wrapper around netdev_alloc_skb()

Use __GFP_COLD flag.

Almost all network drivers now benefit from skb->head_frag
infrastructure.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help