Re: [PATCH 3/8] mISDN: avmfritz use the bigger fifo of chip version 2
flat view
From: David Miller <davem@davemloft.net>
Date: 2012-05-16 05:16:19
From: Karsten Keil <redacted> Date: Wed, 16 May 2012 06:22:49 +0200
+ mode = (AVM_FRITZ_PCIV2 == fc->type) ? HDLC_FIFO_SIZE_128 : 0;
Please don't do this "CONSTANT == variable" type testing order, it's completely unnatural and not something we commonly do elsewhere in the networking code. I know some coders bible somewhere says that this is how you avoid accidental assignments, but it's too ugly to live.