Thread (11 messages) flat view 11 messages, 3 authors, 2012-05-15

Re: [PATCH net-next V1 1/8] net/mlx4: Address build warnings on set but not used variables

From: David Miller <davem@davemloft.net>
Date: 2012-05-15 17:38:17

From: Or Gerlitz <redacted>
Date: Tue, 15 May 2012 10:24:43 +0300
-		err = mlx4_cmd_imm(dev, mac, &out_param, RES_MAC,
-				   RES_OP_RESERVE_AND_MAP, MLX4_CMD_FREE_RES,
-				   MLX4_CMD_TIME_CLASS_A, MLX4_CMD_WRAPPED);
+		(void) mlx4_cmd_imm(dev, mac, &out_param, RES_MAC,
+					RES_OP_RESERVE_AND_MAP, MLX4_CMD_FREE_RES,
+					MLX4_CMD_TIME_CLASS_A, MLX4_CMD_WRAPPED);
Please stop wasting my time.  This is not the correct way to indent
functions that have arguments on multiple lines.

I'll say it one more time:

	The first character must line up with the column right after
	the openning parenthesis on the first line.

This means you DO NOT use only TAB characters and indent the thing
into the solar system like you have above.

Instead you use TAB and SPACE characters, as needed, to line it up
properly, like so:

	func(arg1, arg2,
	     arg3, arg4);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help