Re: [PATCH net-next 1/8] net/mlx4: Address build warnings on set but not used variables

From: Or Gerlitz <redacted>
Date: Tue, 15 May 2012 08:52:06 +0300

On 5/15/2012 7:07 AM, David Miller wrote:

quoted

quoted

-		err = mlx4_qp_detach_common(dev,&qp, rgid->gid, rgid->prot,
+ (void) mlx4_qp_detach_common(dev,&qp, rgid->gid, rgid->prot,
  					    rgid->steer);

You must update the indentation of all the lines comprising of the
function call when you change the indentation of it's initial line.

Just want to make sure I understood right what has to be done here,
e.g in this case its needs to be
like this?

 ...

quoted

-                                           rgid->steer);
+ (void) mlx4_qp_detach_common(dev, &qp, rgid->gid, rgid->prot,
+                                                   rgid->steer);

I can't tell if it's right, becuase it got all reformatted by your
mail client.

You simply need to make sure the arguments on the second and
further lines line up with the column after the openning
parenthesis on the first line.