RE: [net-next 2/8] e1000e: initial support for i217

-----Original Message-----
From: Bjørn Mork [mailto:bjorn@mork.no]
Sent: Saturday, May 05, 2012 1:02 AM
To: Kirsher, Jeffrey T
Cc: davem@davemloft.net; Allan, Bruce W; netdev@vger.kernel.org;
gospo@redhat.com; sassmann@redhat.com
Subject: Re: [net-next 2/8] e1000e: initial support for i217

Jeff Kirsher [off-list ref] writes:

quoted

diff --git a/drivers/net/ethernet/intel/e1000e/defines.h

b/drivers/net/ethernet/intel/e1000e/defines.h

quoted

index 3a50259..11c4666 100644

--- a/drivers/net/ethernet/intel/e1000e/defines.h
+++ b/drivers/net/ethernet/intel/e1000e/defines.h

@@ -74,7 +74,9 @@
 #define E1000_WUS_BC           E1000_WUFC_BC

 /* Extended Device Control */
+#define E1000_CTRL_EXT_LPCD  0x00000004     /* LCD Power Cycle Done

*/

quoted

 #define E1000_CTRL_EXT_SDP3_DATA 0x00000080 /* Value of SW

Definable Pin 3 */

quoted

+#define E1000_CTRL_EXT_FORCE_SMBUS 0x00000004 /* Force SMBus mode*/
 #define E1000_CTRL_EXT_EE_RST    0x00002000 /* Reinitialize from

EEPROM */

quoted

 #define E1000_CTRL_EXT_SPD_BYPS  0x00008000 /* Speed Select Bypass

*/

quoted

 #define E1000_CTRL_EXT_RO_DIS    0x00020000 /* Relaxed Ordering

disable */

The mangled sorting and alignment of the new entries made me wonder if
this was a typo.  But reading further below it looks like
E1000_CTRL_EXT_LPCD is input and E1000_CTRL_EXT_FORCE_SMBUS is output.
If that is correct, then it probably deserves a small comment here
along
with better sorting and alignment to make it clear that the duplicate
value is intentional?


Bjørn

It is a typo.  An updated patch will follow soon.

Thanks for spotting that,
Bruce.