Thread (15 messages) flat view 15 messages, 3 authors, 2012-05-03

Re: [v2 PATCH 3/4] tcp: move stats merge to the end of tcp_try_coalesce

From: David Miller <davem@davemloft.net>
Date: 2012-05-03 08:22:21

From: Eric Dumazet <redacted>
Date: Thu, 03 May 2012 09:52:45 +0200
On Thu, 2012-05-03 at 00:19 -0700, Alexander Duyck wrote:
quoted
This change cleans up the last bits of tcp_try_coalesce so that we only
need one goto which jumps to the end of the function.  The idea is to make
the code more readable by putting things in a linear order so that we start
execution at the top of the function, and end it at the bottom.

I also made a slight tweak to the code for handling frags when we are a
clone.  Instead of making it an if (clone) loop else nr_frags = 0 I changed
the logic so that if (!clone) we just set the number of frags to 0 which
disables the for loop anyway.

Signed-off-by: Alexander Duyck <redacted>
 ...
Thanks a lot Alex, this patch serie looks very good.

Acked-by: Eric Dumazet <edumazet@google.com>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help