RE: [PATCH 01/14 v3] usb/net: rndis: inline the cpu_to_le32() macro

-----Original Message-----
From: netdev-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org 
[mailto:netdev-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Linus Walleij
Sent: 01 May 2012 19:15
To: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Greg 
Kroah-Hartman; David S. Miller; Felipe Balbi
Cc: Jussi Kivilinna; Haiyang Zhang; Wei Yongjun; Ben 
Hutchings; Linus Walleij
Subject: [PATCH 01/14 v3] usb/net: rndis: inline the 
cpu_to_le32() macro

The header file <linux/usb/rndis_host.h> used a number of #defines
that included the cpu_to_le32() macro to assure the result will be
in LE endianness. Inlining this into the code instead of using it
in the code definitions yields consolidation opportunities later
on as you will see in the following patches. The individual
drivers also used local defines - all are switched over to the
pattern of doing the conversion at the call sites instead.

Signed-off-by: Linus Walleij <redacted>
---
 drivers/net/usb/rndis_host.c      |   52 +++++++-------
 drivers/net/wireless/rndis_wlan.c |  138 
+++++++++++++++++++------------------
 include/linux/usb/rndis_host.h    |   84 +++++++++++-----------
 3 files changed, 139 insertions(+), 135 deletions(-)

diff --git a/drivers/net/usb/rndis_host.c 

b/drivers/net/usb/rndis_host.c
index c8f1b5b..05cad0b 100644

--- a/drivers/net/usb/rndis_host.c
+++ b/drivers/net/usb/rndis_host.c

@@ -78,10 +78,10 @@ static void rndis_msg_indicate(struct 

usbnet *dev, struct rndis_indicate *msg,
 		dev->driver_info->indication(dev, msg, buflen);
 	} else {
 		switch (msg->status) {
-		case RNDIS_STATUS_MEDIA_CONNECT:
+		case cpu_to_le32(RNDIS_STATUS_MEDIA_CONNECT):
 			dev_info(udev, "rndis media connect\n");
 			break;