Re: [PATCH net-next] netem: add ECN capability

On Tue, 2012-05-01 at 09:59 -0700, Stephen Hemminger wrote:

The concept is fine, but a couple of questions.
 1. Why a whole u32 for boolean?

a boolean in this structure wont save space, and this file is full of
u32. Why bother ?

IMHO boolean are fine for function arguments, but in a structure, not
very helpful.

 2. The logic in this part of netem is setup to handle case of random duplication
    combined with random loss. With ecn option set, will this code correctly
    handled a duplication combined with a loss and send one packet?
    It looks like the new code would change that behaviour.

Hmm, I'll take a look.