+
+struct atl1c_platform_patch {
+     u16 pci_vid;
+     u16 pci_did;
+     u8  pci_revid;
+     u16 subsystem_vid;
+     u16 subsystem_did;
+     u32 patch_flag;
+#define ATL1C_LINK_PATCH     0x1
+};
+static struct atl1c_platform_patch plats[] = {

This should be static const.

+{0x1969, 0x2060, 0xC1, 0x1019, 0x8152, 0x1},

-------------------------------------------------------------------------------------------------------
How about if I revise it as:

static const struct atl1c_platform_patch plats[] __devinitdata = {
....}

the array is only used by atl1c_probe function. is it appropriate to add '__devinitdata' here ?



Thanks
-Xiong