Thread (4 messages) flat view 4 messages, 3 authors, 2012-04-10

Re: [PATCH] davinci_emac: Add cpu_freq support

From: Ben Hutchings <hidden>
Date: 2012-04-09 15:56:25
Also in: lkml

On Mon, 2012-04-09 at 16:19 +0530, Manjunathappa, Prakash wrote:
quoted hunk ↗ jump to hunk
Reconfigure interrupt coalesce parameter for changed emac bus_freq
due to DVFS.

Signed-off-by: Manjunathappa, Prakash <redacted>
---
 drivers/net/ethernet/ti/davinci_emac.c |   60 ++++++++++++++++++++++++++++++++
 1 files changed, 60 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c
index 174a334..11d3bd7 100644
--- a/drivers/net/ethernet/ti/davinci_emac.c
+++ b/drivers/net/ethernet/ti/davinci_emac.c
@@ -50,6 +50,7 @@
 #include <linux/ctype.h>
 #include <linux/spinlock.h>
 #include <linux/dma-mapping.h>
+#include <linux/cpufreq.h>
 #include <linux/clk.h>
 #include <linux/platform_device.h>
 #include <linux/semaphore.h>
@@ -344,6 +345,9 @@ struct emac_priv {
 	/*platform specific members*/
 	void (*int_enable) (void);
 	void (*int_disable) (void);
+#ifdef CONFIG_CPU_FREQ
+	struct notifier_block	freq_transition;
+#endif
 };
 
 /* clock frequency for EMAC */
@@ -1761,6 +1765,46 @@ static const struct net_device_ops emac_netdev_ops = {
 #endif
 };
 
+#ifdef CONFIG_CPU_FREQ
+static int davinci_emac_cpufreq_transition(struct notifier_block *nb,
+				     unsigned long val, void *data)
+{
+	int ret = 0;
+	struct emac_priv *priv;
+
+	priv = container_of(nb, struct emac_priv, freq_transition);
+	if (priv->coal_intvl != 0) {
+		if (val == CPUFREQ_POSTCHANGE) {
+			if (emac_bus_frequency != clk_get_rate(emac_clk)) {
+				struct ethtool_coalesce coal;
+
+				emac_bus_frequency = clk_get_rate(emac_clk);
+
+				priv->bus_freq_mhz = (u32)(emac_bus_frequency /
+						1000000);
+				coal.rx_coalesce_usecs = (priv->coal_intvl
+						<< 4);
+				ret = emac_set_coalesce(priv->ndev, &coal);
[...]

Ick.  Why don't you break up emac_set_coalesce() so that you can push
this one value to the hardware without faking up a struct
ethtool_coalesce?  Don't you need to push it on reset/resume anyway?

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help