Re: net: kernel BUG() in net/netns/generic.h:45
From: "[PATCH 1/2]"@fess.ebiederm.org, "net:In"@fess.ebiederm.org,
unregister_netdevice_notifier@fess.ebiederm.org,
unregister@fess.ebiederm.org, the@fess.ebiederm.org,
"netdevices."@fess.ebiederm.org
Date: 2012-04-07 01:27:32
Also in:
lkml
Subsystem:
networking [general], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2012-04-07 · Re: net: kernel BUG() in net/netns/generic.h:45 · Eric W. Biederman <hidden>
- 2012-04-06 · Re: net: kernel BUG() in net/netns/generic.h:45 · Sasha Levin <hidden>
- 2012-04-05 · Re: net: kernel BUG() in net/netns/generic.h:45 · Eric W. Biederman <hidden>
- 2012-04-05 · net: kernel BUG() in net/netns/generic.h:45 · Sasha Levin <hidden>
We already synthesize events in register_netdevice_notifier and synthesizing events in unregister_netdevice_notifier allows to us remove the need for special case cleanup code. This change should be trivially safe as it adds no new cases for existing callers of unregister_netdevice_notifier to handle. Signed-off-by: Eric W. Biederman <redacted> --- net/core/dev.c | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 452db70..77c0a87 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c@@ -1410,14 +1410,34 @@ EXPORT_SYMBOL(register_netdevice_notifier); * register_netdevice_notifier(). The notifier is unlinked into the * kernel structures and may then be reused. A negative errno code * is returned on a failure. + * + * After unregistering unregister and down device events are synthesized + * for all devices on the device list to the removed notifier to remove + * the need for special case cleanup code. */ int unregister_netdevice_notifier(struct notifier_block *nb) { + struct net_device *dev; + struct net *net; int err; rtnl_lock(); err = raw_notifier_chain_unregister(&netdev_chain, nb); + if (err) + goto unlock; + + for_each_net(net) { + for_each_netdev(net, dev) { + if (dev->flags & IFF_UP) { + nb->notifier_call(nb, NETDEV_GOING_DOWN, dev); + nb->notifier_call(nb, NETDEV_DOWN, dev); + } + nb->notifier_call(nb, NETDEV_UNREGISTER, dev); + nb->notifier_call(nb, NETDEV_UNREGISTER_BATCH, dev); + } + } +unlock: rtnl_unlock(); return err; }
--
1.7.2.5