Re: [PATCH] sky2: fix missing register reset on error path in sky2_test_msi()

[PATCH] sky2: fix missing register reset on error path in sky2_test_msi() · Lino Sanfilippo <LinoSanfilippo@gmx.de> · 2012-03-30
Re: [PATCH] sky2: fix missing register reset on error path in sky2_test_msi() · David Miller <davem@davemloft.net> · 2012-04-01
Re: [PATCH] sky2: fix missing register reset on error path in sky2_test_msi() · Stephen Hemminger <hidden> · 2012-04-03
Re: [PATCH] sky2: fix missing register reset on error path in sky2_test_msi() · Lino Sanfilippo <LinoSanfilippo@gmx.de> · 2012-04-03
Re: [PATCH] sky2: fix missing register reset on error path in sky2_test_msi() · David Miller <davem@davemloft.net> · 2012-04-03
Re: [PATCH] sky2: fix missing register reset on error path in sky2_test_msi() · Stephen Hemminger <hidden> · 2012-04-03
Re: [PATCH] sky2: fix missing register reset on error path in sky2_test_msi() · David Miller <davem@davemloft.net> · 2012-04-03

From: Stephen Hemminger <hidden>
Date: 2012-04-03 18:55:53
Also in: lkml

On Fri, 30 Mar 2012 19:36:16 +0200
Lino Sanfilippo [off-list ref] wrote:

In sky2_test_msi() the temporarily set SW IRQ in B0 register is not reset in case
that request_irq() fails.
With this patch we only set the interrupt mask if request_irq() was successful.

Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>

Ok, but this is a non-serious error case. If request_irq() fails here,
the driver is going to fail to load and on the failure path of
sky2_probe will reset the chip on the way out.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help