RE: [PATCH 02/14 v2] usb/net: rndis: break out <linux/rndis.h> defines

________________________________________

From: David Miller [davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org]
Sent: Wednesday, April 25, 2012 7:45 PM
To: Haiyang Zhang
Cc: linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org; netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org; balbi-l0cyMroinI0@public.gmane.org; jussi.kivilinna-E01nCVcF24I@public.gmane.org; yongjun_wei-zrsr2BFq86L20UzCJQGyNP8+0UxHXcjY@public.gmane.org; ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org
Subject: Re: [PATCH 02/14 v2] usb/net: rndis: break out <linux/rndis.h> defines

From: Haiyang Zhang <redacted>
Date: Wed, 25 Apr 2012 20:38:31 +0000

quoted

Reviewed-by: Haiyang Zhang <redacted>

I don't think you really thoroughly reviewed this patch, otherwise
you would have noticed the duplicate definitions that result from
this patch which adds hundreds of warnings to the build.

Actually, I did see the duplicate defines, I also noticed the author pointing out
-- "The compilation screams about double-defines all over the place." In my
test, the warnings go away after all patches applied.

But, thanks for your comments. I believe the author has now realized that
consolidating the defines and removing the duplicates should be done in one
patch so that there are no warnings.

Thanks,
- Haiyang
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html