Re: [PATCH] b44: properly use pr_fmt()
From: David Miller <davem@davemloft.net>
Date: 2012-04-24 04:48:03
From: "Luis R. Rodriguez" <redacted> Date: Mon, 23 Apr 2012 19:46:43 -0700
From: "Luis R. Rodriguez" <redacted> pr_fmt() is either defined or we redefine it. Typically drivers define it prior to including printk.h but this is done under the assumption that no other subsystem it uses has already defined pr_fmt(). In such cases pr_fmt() should be undefined and redefined. Doing this properly shaves down compilation time quite considerably. Signed-off-by: Luis R. Rodriguez <redacted>
Every driver defines pr_fmt then includes the headers. I do not see any other place which performs the initial undef of pr_fmt like you want to start doing here. If there is a reason we should start doing this, it would appear to be a universal reason, not one specific to this driver. If that's the case, we should formally agree to this and then work on gradually converting all the drivers in reasonably sized chunks. Either way I can't apply this patch as-is, sorry Luis.