Thread (2 messages) 2 messages, 2 authors, 2012-04-20

Re: [PATCH 1/3] don't attach a task to a dead cgroup

From: Tejun Heo <hidden>
Date: 2012-04-19 22:53:22
Also in: cgroups

On Thu, Apr 19, 2012 at 07:49:16PM -0300, Glauber Costa wrote:
quoted hunk
Not all external callers of cgroup_attach_task() test to
see if the cgroup is still live - the internal callers at
cgroup.c does.

With this test in cgroup_attach_task, we can assure that
no tasks are ever moved to a cgroup that is past its
destruction point and was already marked as dead.

Signed-off-by: Glauber Costa <redacted>
CC: Tejun Heo <redacted>
CC: Li Zefan <redacted>
CC: Kamezawa Hiroyuki <redacted>
---
 kernel/cgroup.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index b61b938..932c318 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1927,6 +1927,9 @@ int cgroup_attach_task(struct cgroup *cgrp, struct task_struct *tsk)
 	struct cgroup_taskset tset = { };
 	struct css_set *newcg;
 
+	if (cgroup_is_removed(cgrp))
+		return -ENODEV;
+
Isn't the test in cgroup_lock_live_group() enough?

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help