Re: [PATCH 10/11] batman-adv: print OGM seq numbers as unsigned long

From: Antonio Quartulli <redacted>
Date: Wed, 18 Apr 2012 09:01:35 +0200

On Wed, Apr 18, 2012 at 08:47:00AM +0200, Antonio Quartulli wrote:

quoted

On Tue, Apr 17, 2012 at 10:47:46 -0400, David Miller wrote:

quoted

From: Antonio Quartulli <redacted>
Date: Tue, 17 Apr 2012 13:58:26 +0200

quoted

OGM sequence numbers are declared as uint32_t and so they have to printed
using %u instead of %d in order to avoid wrong representations.

Signed-off-by: Antonio Quartulli <redacted>

Fix this commit message subject, "%u" is "unsigned int" not
"unsigned long"

"unsigned long" would be "%lu"

There is a problem here. On my machine (x86_64) I have:

typedef unsigned int __u32;
typedef         __u32           uint32_t;


So I should use %u to print my uint32_t variable (as I reported in my commit
message).

Probably this is not the case on each and every architecture?
If so, how could I handle it?

The problem is not the patch, it's your commit message
you say "print ... as unsigned long", you're not printing
it as unsigned long, you're printing it as unsigned int.