Re: [PATCH 05/11] batman-adv: handle routing code initialization properly
From: David Miller <hidden>
Date: 2012-04-18 02:46:30
Also in:
batman
From: Antonio Quartulli <redacted> Date: Tue, 17 Apr 2012 13:58:21 +0200
quoted hunk
@@ -30,10 +30,11 @@ #include "send.h" #include "bat_algo.h" -static void bat_iv_ogm_iface_enable(struct hard_iface *hard_iface) +static int bat_iv_ogm_iface_enable(struct hard_iface *hard_iface) { struct batman_ogm_packet *batman_ogm_packet; unsigned long random_seqno; + int res = -1; /* randomize initial seqno to avoid collision */ get_random_bytes(&random_seqno, sizeof(unsigned long));
Use real error codes, even as a default, instead of meaningless values like -1.