Re: [PATCH 2/2] ath9k: Gather and report IRQ sync_cause errors.

2012.04.17. 23:13 keltezéssel, Ben Greear írta:

On 04/17/2012 02:07 PM, Gabor Juhos wrote:

quoted

quoted

From: Ben Greear<greearb-my8/4N5VtI7c+919tysfdA@public.gmane.org>

Report all defined sync_cause errors in debugfs
to aid with debugging.

Use a macro to print out the interrupts file contents
to decrease code duplication.

Now, that the patch is in wireless-testing, I have noticed a minor problem
with it.

Thanks for the report.

Np.

I'll fix this shortly.

Thanks,
Gabor

Thanks,
Ben

quoted

quoted

+#ifdef CONFIG_ATH9K_DEBUGFS
+void ath9k_debug_sync_cause(struct ath_common *common, u32 sync_cause);
+#else
+static void ath9k_debug_sync_cause(struct ath_common *common, u32
sync_cause) {}

Due to a missing 'inline' keyword, this causes a bunch of warnings if
CONFIG_ATH9K_DEBUGFS is not enabled:

    CC [M]  drivers/net/wireless/ath/main.o
    CC [M]  drivers/net/wireless/ath/regd.o
    CC [M]  drivers/net/wireless/ath/hw.o
    CC [M]  drivers/net/wireless/ath/key.o
    LD [M]  drivers/net/wireless/ath/ath.o
    CC [M]  drivers/net/wireless/ath/ath9k/beacon.o
  drivers/net/wireless/ath/ath9k/hw.h:962: warning: ‘ath9k_debug_sync_cause’
defined but not used

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html