Re: [PATCH] can: fix sparse warning for cgw_list
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: 2012-03-26 05:04:40
Also in:
linux-can
On 26.03.2012 01:05, dbaluta@ixiacom.com wrote:
From: Daniel Baluta <redacted> Make cgw_list static to remove the following sparse warning: net/can/gw.c:69:1: warning: symbol 'cgw_list' was not declared. Should it be static? Signed-off-by: Daniel Baluta <redacted>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net> Hello Daniel, cgw_list is indeed only a local structure. Don't know why i didn't declare it to be static. If it silences a sparse warning the better :-) Thanks, Oliver
quoted hunk ↗ jump to hunk
--- net/can/gw.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/net/can/gw.c b/net/can/gw.c index 3d79b12..b41acf2 100644 --- a/net/can/gw.c +++ b/net/can/gw.c@@ -66,7 +66,7 @@ MODULE_LICENSE("Dual BSD/GPL"); MODULE_AUTHOR("Oliver Hartkopp <oliver.hartkopp@volkswagen.de>"); MODULE_ALIAS("can-gw"); -HLIST_HEAD(cgw_list); +static HLIST_HEAD(cgw_list); static struct notifier_block notifier; static struct kmem_cache *cgw_cache __read_mostly;