here "mac" is in "u64" and I have casted it to "__le64".
Because its required there.

If you have any better suggestion, please let me know.


regards
santosh

On Mon, Mar 12, 2012 at 3:07 PM, David Laight [off-list ref] wrote:

quoted

-----Original Message-----
From: netdev-owner@vger.kernel.org
[mailto:netdev-owner@vger.kernel.org] On Behalf Of santosh
prasad nayak
Sent: 11 March 2012 09:17
To: Rajesh Borundia
Cc: Sony Chacko; netdev; linux-kernel; kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] netxen: qlogic ethernet : Fix Endian Bug.

Thanks Rajesh for clarification.
Included all your inputs in the following patch.
This is for review not a formal one. Once review is done I will send a
formal patch.

I'm not sure of the exact nature of the issues here,
but whenever I see code that casts between the addresses
of integer types large bells start ringing - such code
tends to have unwanted dependencies against the sizes
and endiannesses of the relevant fields.
This code might be ok, but lines like:

quoted

+     if (*(__le64 *)mac == cpu_to_le64(~0ULL)) {

rather give me the willies.

       David