Thread (5 messages) 5 messages, 2 authors, 2012-03-12

Re: [PATCH 3/3 v2] netxen: qlogic ethernet : Fix endian bug.

From: David Miller <davem@davemloft.net>
Date: 2012-03-12 09:37:11
Also in: kernel-janitors, lkml

From: santosh prasad nayak <redacted>
Date: Mon, 12 Mar 2012 14:45:38 +0530
Subject: [PATCH 3/3 v2] netxen: qlogic ethernet : Fix endian bug.

Change the datatype of "ip_addr" to __be32 as 'ip' should be in
big endian format.

Adapter needs "ip address" in big endian format stored at lower 32bit
of req.word[1]. netxen_config_ipaddr() now receives 'ip' in big endian
format. To satisfy adapter's need, use memcpy() to copy byte by byte
of 'ip' into lower 32bit of req.word[1].

Mac address and serial number of adapter need to be in little endian format.
Change the data type of the related  variables to __le32 / __le64 or cast it
explicitly to __le32 / __le64 depending upon the requirement.
This looks a lot better.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help