Thread (8 messages) 8 messages, 2 authors, 2012-03-12

RE: [PATCH 1/2] net/hyperv: Fix data corruption in rndis_filter_receive()

flat view

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2012-03-09 21:55:22
Also in: lkml

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Friday, March 09, 2012 4:51 PM
To: Haiyang Zhang
Cc: KY Srinivasan; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
devel@linuxdriverproject.org
Subject: Re: [PATCH 1/2] net/hyperv: Fix data corruption in
rndis_filter_receive()

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: Fri,  9 Mar 2012 13:27:16 -0800
quoted
Limiting the memcpy to be the sizeof(struct rndis_message) can
truncate the message if there are Per-Packet-Info or Out-of-Band data.

In my earlier patch (commit 45326342), the unnecessary kmap_atomic and
kunmap_atomic surrounding this memcpy have been removed because the
memory in the receive buffer is always mapped. This memcpy is not
necessary either. To fix the bug, I removed the memcpy.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Well, where the heck is patch 2/2?
It's still in the mail server's send queue. This happens sometimes on our mail server.
But it should reach you in half hour or so...

- Haiyang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help