Thread (6 messages) 6 messages, 5 authors, 2012-03-09

Re: Resend: [PATCH] Bluetooth: Fix Endian Bug.

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2012-03-08 17:53:27
Also in: kernel-janitors, linux-bluetooth, lkml

Hi Gustavo,
quoted
Fix network to host endian conversion for L2CAP chan id.

Signed-off-by: Santosh Nayak <redacted>
---
 net/bluetooth/l2cap_sock.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
index 401d942..86d5067 100644
--- a/net/bluetooth/l2cap_sock.c
+++ b/net/bluetooth/l2cap_sock.c
@@ -82,7 +82,7 @@ static int l2cap_sock_bind(struct socket *sock, struct sockaddr *addr, int alen)
 	}
 
 	if (la.l2_cid)
-		err = l2cap_add_scid(chan, la.l2_cid);
+		err = l2cap_add_scid(chan, __le16_to_cpu(la.l2_cid));
This is kind weird, la.l2_cid comes from the user, so it is already in host
endian. No need for convertions here.
CID and PSM are provided in little endian by user space.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help