Re: [PATCH 1/4] Netfilter: Merge ipt_LOG and ip6_LOG into xt_LOG

Am 04.03.2012 12:12, schrieb Pablo Neira Ayuso:

On Fri, Mar 02, 2012 at 05:52:50PM +0100, Richard Weinberger wrote:

quoted

Am 02.03.2012 17:49, schrieb Pablo Neira Ayuso:

quoted

On Thu, Mar 01, 2012 at 10:39:15PM +0100, Richard Weinberger wrote:

quoted

Am 01.03.2012 12:27, schrieb Pablo Neira Ayuso:

quoted

While merging ipt_LOG and ip6t_LOG, you introduced some bug that
corrupts the log line. Note the extra PROTO=, I don't have any UDPLITE
traffic here.

Looks like a missing break in one switch.

I got confused by my own logic. :-\
Does the attached patch fix the issue?
It's based on "Netfilter: xt_LOG: Add timestamp support"

This patch lacks of description. If you don't make it myself, I have
to do it for you :-(

Please, send me patches following the standard format next time.

It was a "does this patch solve the problem"-Patch.
Does it fix the problem?

If so, I'll send an official one...

Sorry, that's too much overhead. I don't mind testing it, but I want
to apply it as soon as it fixes the problem ;-)

I'll try to reproduce your problem and test the fix for my own.

Thanks,
//richard