Re: Resend: [PATCH] Bluetooth: Fix Endian Bug.

Hi Santosh,

On Thu, Mar 01, 2012 at 07:34:58PM +0530, santosh prasad nayak wrote:

Andrei,

I could not get you.

Do you want me to resend the patch with subject,
  "[PATCH] Bluetooth: Fix network to host endian conversion for L2CAP
chan id."  ?

No, the main concern was your commit message which is changelog and should
come after "---" as it is shown in the example below.

quoted

On Thu, Mar 01, 2012 at 04:29:21PM +0530, santosh nayak wrote:

quoted

From: Santosh Nayak <redacted>

Fix for endian bug.

Fix for null dereferenced removed as it is already
submitted by Andrei.

Signed-off-by: Santosh Nayak <redacted>
---
 net/bluetooth/l2cap_sock.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

We prefer following commit log (this is the example)

<------8<----------------------------------------------------------
|  From: Santosh Nayak [off-list ref]
|
|  Fix network to host endian conversion for L2CAP chan id.
|
|  Signed-off-by: Santosh Nayak [off-list ref]
|
|  ---
|          * v2 Fix for null dereferenced removed as it is already
|          submitted by Andrei.
|
|    net/bluetooth/l2cap_sock.c |    5 +++--
|    1 files changed, 3 insertions(+), 2 deletions(-)
|
<------8<----------------------------------------------------------

Best regards 
Andrei Emeltchenko