Thread (4 messages) flat view 4 messages, 2 authors, 2012-03-01

Re: [PATCH 3/3] netfilter: Remove redundant code.

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2012-03-01 10:23:50
Also in: bridge, kernel-janitors, lkml, netfilter-devel

On Thu, Mar 01, 2012 at 02:47:46PM +0530, santosh nayak wrote:
quoted hunk ↗ jump to hunk
From: Santosh Nayak <redacted>

Remove the redundant code.

Signed-off-by: Santosh Nayak <redacted>
---
 net/bridge/netfilter/ebtables.c |   18 ++++++------------
 1 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index 9c0f177..1efc234 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -226,10 +226,8 @@ unsigned int ebt_do_table (unsigned int hook, struct sk_buff *skb,
 
 		if (EBT_MATCH_ITERATE(point, ebt_do_match, skb, &acpar) != 0)
 			goto letscontinue;
-		if (acpar.hotdrop) {
-			read_unlock_bh(&table->lock);
-			return NF_DROP;
-		}
+		if (acpar.hotdrop)
+			goto out;
This is really broken! there's no "out" label in ebt_do_table as in
the previous patch!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help