Re: [PATCH] f_phonet: fix skb truesize underestimation

On Wed, Mar 28, 2012 at 8:43 AM, Felipe Balbi [off-list ref] wrote:

On Wed, Mar 28, 2012 at 05:33:10AM -0400, David Miller wrote:

quoted

From: Felipe Balbi <redacted>
Date: Wed, 28 Mar 2012 11:55:36 +0300

quoted

On Tue, Mar 27, 2012 at 10:51:09PM -0400, David Miller wrote:

quoted

From: Eric Dumazet <redacted>
Date: Tue, 27 Mar 2012 06:04:02 -0700

quoted

Now skb_add_rx_frag() has a truesize parameter, we can fix f_phonet to
properly account truesize of each fragment : a full page.

Signed-off-by: Eric Dumazet <redacted>

Applied.

did you apply both patches ?

You never need to ask me these kinds of questions, you can
either check my GIT tree or look at:

http://patchwork.ozlabs.org/project/netdev/list/?state=3

I'm asking because drivers/usb/gadget/ should either go through me or
you should wait for my Acked-by. Now it's too late for that, but next
time for my Ack.

Hi Felipe,

Being in the MAINTAINERS file is best interpreted as "I care about
this driver/code/subsystem, and I'll do my best to fix/integrate for it,
and I want to know about changes to it".

It has never meant that all patches to that MAINTAINER's code must
be OK'd by that one particular maintainer before being committed.

In the last twenty years, I can't ever recall any one driver/subsystem
where one individual had the ultimate veto (excluding Linus).  And
that is a good thing.

If a commit has dependencies to low level skb accounting, then it
makes perfect sense for it to be in the tree where those accounting
changes are made.  Even more sense for it to be done by the
people who know those internals better than anyone else.

Speaking for myself, if I had networking code that Eric and Dave
made changes to, I'd be pretty damn happy that smarter people
than myself did the changes for me, and that they were nice enough
to have CC'd me on the changes as a courtesy.

Just my $0.02.
Paul.

--
balbi

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html