Re: [PATCH] net/ethernet: ks8851_mll fix rx frame buffer overflow

On Wed, Mar 28, 2012 at 09:39:51AM +0200, Eric Dumazet wrote:

On Wed, 2012-03-28 at 09:05 +0200, Raffaele Recalcati wrote:

quoted

Hi Eric,

On 07:39 Tue 27 Mar     , Eric Dumazet wrote:

quoted

Le mardi 27 mars 2012 ?? 15:01 +0200, Davide Ciminaghi a ??crit :

...

So the limit should be 255, not 256.
(0xFFFF >> 8 -> 0xFF)

ks->frame_cnt = ks_rdreg16(ks, KS_RXFCTR) >> 8;

I cant see how 256 can be stored in a 8bit field ?

you're right, we'll resend the patch with 255.
Well actually, since the chip appears to have 12K of internal rx buffers
and the shortest ethernet frame should be 64 bytes long, maybe the limit could
be set to 12*1024/64 = 192 frames, but I think 255 is safer.
 

Thanks and regards
Davide