Thread (2 messages) flat view 2 messages, 2 authors, 2012-03-27

Re: [PATCH net/core] dev_forward_skb() should clear skb_iif

From: David Miller <davem@davemloft.net>
Date: 2012-03-27 21:42:29

From: Benjamin LaHaise <bcrl@kvack.org>
Date: Tue, 27 Mar 2012 12:29:20 -0400
While investigating another bug, I found that the code on the incoming path
in __netif_receive_skb will only set skb->skb_iif if it is already 0.  When
dev_forward_skb() is used in the case of interfaces like veth, skb_iif may
already have been set.  Making dev_forward_skb() cause the packet to look
more like a newly received packet would seem to the the correct behaviour
here, as otherwise the wrong incoming interface can be reported for such a
packet.
Same problems as your ipv4 multicast patch, I'm not applying this.

You must learn how to properly submit your changes, otherwise I
guarentee all of your work will hit the bit bucket.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help