Re: [PATCH] net: reference the ipv4 sysctl table header
From: David Miller <davem@davemloft.net>
Date: 2012-03-26 22:24:16
From: David Miller <davem@davemloft.net>
Date: 2012-03-26 22:24:16
From: Djalal Harouni <redacted> Date: Mon, 26 Mar 2012 23:23:59 +0100
+static struct ctl_table_header *ip4_base;
+
/*
* We really need to sanitize the damn ipv4 init order, then all
* this nonsense will go away.
*/
-void __init ip_static_sysctl_init(void)
+int __init ip_static_sysctl_init(void)
{
- register_sysctl_paths(ipv4_path, ipv4_skeleton);
+ ip4_base = register_sysctl_paths(ipv4_path, ipv4_skeleton);This is so incredibly stupid, just panic() or similar if this returns NULL. And find another way to annotate this for memleak so we don't need to waste an entire pointer, which is never used, in the data section.